Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emoji work with toc (#417) #418

Merged
merged 2 commits into from
May 12, 2018
Merged

fix: emoji work with toc (#417) #418

merged 2 commits into from
May 12, 2018

Conversation

meteorlxy
Copy link
Member

fix #417

Before

image

After

image

ycmjason
ycmjason approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@ycmjason ycmjason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we always have issues with headers and emoji.

This LGTM!

@ulivz ulivz merged commit 1b9012e into vuejs:master May 12, 2018
@meteorlxy meteorlxy deleted the emoji-in-toc branch May 13, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycmjason ycmjason ycmjason approved these changes

@ulivz ulivz ulivz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emoji does not work with TOC now
3 participants
@meteorlxy @ycmjason @ulivz